2017-12-08

NECKO WEEKLY MEETING NOTES

Thurs December 7th, 2017

TRIAGE

  • Note: use these 2 queries when you're on triage duty: all bugs should be [necko-triaged] and have a priority

    • UNTRIAGED bugs: https://mzl.la/2wAv7XZ
    • MALFORMED bugs (have necko-triaged but no priority): https://mzl.la/2xXf2jc

  • P1 bugs https://mzl.la/2he1C85

  • P2 bugs https://mzl.la/2yaD1aO

  • P3 bugs (backlog) https://mzl.la/2xcYzEL

  • P5 bugs (would take): https://mzl.la/2hdnQXy

  • Triage Notes

    • Android crashes on infra are currently not symbolicated: https://bugzilla.mozilla.org/show_bug.cgi?id=1389805 (makes triaging/diagnosing android crash bugs hard/impossible)

Nick

Gary

Honza

Junior

Michal

Amy <<<<<===== Dec 8 -> 14

Daniel

Kershaw

Valentin

SC

Dragana

Round Table:

  • dns resolver rewrite vs incremental fixes?
  • Fx56 statcounter drop 5% -> anything network and tracking protection related?
  • Bug 1420872 - Uploading images hangs whole network stack
  • 1409634 Firefox using 35-45% cpu for no apparent reason

Nick

Honza

Michal

  • triage
  • [landed] 1418854 Intermittent SUMMARY: AddressSanitizer: heap-use-after-free
  • [landed] 1394564 Version 55 breaks sending large amounts of data over web sockets.
  • Bug 1412022 Intermittent dom/base/test/test_websocket1.html | the ws connection in test 6 should be closed cleanly
  • Bug 1052467 Intermittent talos "TalosError: timeout"

Patrick

last week: mpendingq, 256fd telemetry, 0.9 telemetry, namespaces, neat tls, alt-svc, immutable bug, some non-necko stuff this week: neat tls, alt-svc, immutable bug, some non-necko stuff. more reviews.

Daniel

  • TRR (Trusted Recursive Resolver over DOH)

Valentin

Bug 1414425 - Appropriate principal must be set for meta refresh

Bug 1422518 - Meta refresh principal with about:blank

Bug 1415536 - Extend NotifyNetworkActivity [lots of reviews]

Bug 1422173 - Crash in nsDNSRecord::GetNextAddr

  • filed Bug 1423945 - Refactor DNS code Bug 1420954 - Make nsIURIMutator setters return nsIURIMutator so we can chain setters

Bug 908413 - data: URI with bogus type is content-sniffed instead of being treated as text/plain

Dragana

http-auth dialog

UnknownDecoder crash

TFO

QUIC

NEAT

Gary

Bug 1415115 - PERMA-FAIL | accessible/tests/mochitest/events/docload/test_docload_root.html | Test timed out.

Junior

Bug 1420334 - Intermittent any test PROCESS-CRASH | application crashed [@ mozilla::TimeStamp::operator-(mozilla::TimeStamp const &)] after Assertion failure: !aOther.IsNull() (Cannot compute with aOther null value)

  • r+, regression of 55 but exposed by enabling rcwn, root cause is race condition between onCacheEntryCheck(not limited to main thread) and HttpChannel::OnStartRequest (main thread) Bug 1419658 - Basic (probably digest?) authentication broken with non ASCII chars

  • WIP, cannot find a Base64 encoding for wide chars Triage

  • problem: priority of Bug 1420872 - Uploading images hangs whole network stack (only with McAFee)

  • problem: do we need to triage on sec bugs

Amy

Bug 1413512 - Get telemetry on how often we see HTTP(S) -> FTP redirects

  • Have to modify the patch from SC's suggestions. Bug 1421324 - Overwrite of existing cookie with HttpOnly flagged cookie results in HttpOnly being ignored by Firefox

  • Finished the implementation.

  • r? jdm

Kershaw

Bug 1413999 - Add support for Server-Timing HTTP trailing header

*- All parches except the test case are waiting for review

SC

[Socket Process]

  • evaluating impact on PSM/NSS with @dkeeler

  • PSM/NSS access a lot of chrome-process-only data

  • preference, data file in profile folder, system file in /dev and /etc, load 3rd-party DLL

  • update requirements in https://wiki.mozilla.org/Necko:_Sandboxing_TCP/UDP_socket_in_a_separate_process#Requirements

  • thinking about moving cache to socket process as well for simplicity

  • Prototyping

  • implementing UDPSocket with Endpoint utility, ongoing [Others]

  • Bug 1417901 - Firefox is changing 301 HTTP redirects to HTTPS when done on an HTTPS server

  • for top-level navigation, we need to disable Upgrade-Insecure-Request if redirect to non-secure cross-origin URL

  • f+ for WIP

  • security bug

  • provide second WIP, f-'ed by @mayhemer

  • need to find some other solution that not play with refcount