2017-06-30

NECKO WEEKLY MEETING NOTES

Thurs June 14th, 2017

STICKY

  • Triage duty: dragana
  • new untriaged bugs: https://tinyurl.com/zhk9yjf
  • NECKO-ACTIVE bugs: https://tinyurl.com/j8pj35u
  • NECKO NEXT bugs: https://tinyurl.com/zjwjfee
  • NECKO-BACKLOG bugs: https://tinyurl.com/hpkcxx3

Round Table:

  • Proposal: once at month (whichever triage cycle includes the 1st of the month), we have two triagers: one regular, and one person goes over the necko-backlog|next|active lists
    • look at active just to make sure they're all assigned

---PROJECT UPDATES--- - rust-url meeting notes: https://public.etherpad-mozilla.org/p/mozloha-rust-url - rcwn https://public.etherpad-mozilla.org/p/mozaloha-rcwn - service workers https://public.etherpad-mozilla.org/p/mozaloha-sw-necko

QUIC (Pat, Dragana, Daniel)

Race-Cache-with-Network (Michal, Valentin, Junior)

  • Enabled on nightly for a while
  • Next: land performance stats

Context-Driven Priority (Honza, Kershaw, Amy, Gary, Nick)

  • maybe we should give this a read? http://web.mit.edu/ravinet/www/polaris_nsdi16.pdf

PBackgroundHttp (SC, NIck)

Nick

  • NTLM Hell

Honza

Michal

  • 1367742 Crash in mozilla::net::nsHttpChannel::ContinueProcessRedirection
  • 1368887 Crash in mozilla::net::CacheFile::IsKilled
  • 1325336 Generate statistics for cache performance on the given HW
  • 1369051 Assertion failure: !entry || !entry->IsFresh(), at /home/nicolas/mozilla/contrib-push/netwerk/cache2/CacheIndex.cpp:3129
  • 1372993 Assertion failure: chunkCheck == chunk, at …/netwerk/cache2/CacheFile.cpp:1736

Patrick

last week: mpendingq, 256fd telemetry, 0.9 telemetry, namespaces, neat tls, alt-svc, immutable bug, some non-necko stuff this week: neat tls, alt-svc, immutable bug, some non-necko stuff. more reviews.

Daniel

  • 3 days QUIC interim in Paris last week (attended from remote)
  • "HTTP Workshop" in London
  • queued up some reviews to deal with
  • 1360164 - The first async XHR done during startup blocks the main thread while initializing nsProtocolProxyService
  • 1364250 - Move JAR channel I/O off of main thread
  • 1366222 - Basic authentication 401 message flood

Valentin

bug 1359697 - don't poll for CP detection [landed]

bug 1356097 - investigate weird telemetry metrics [landed]

Bug 1368549 - Remove MOZ_WIDGET_GONK from netwerk/* [landed]

bug 945240 - make URLs hold punycode hosts

RCWN - telemetry should be available in the next few days, so we can see if it made any improvement

Looked into 1367810 - Crash in mozilla::net::nsHttpChannel::CallOnStartRequest

Dragana

TFO - second time: 2 crashes left

rel=preload

QUIC

Bug 1357678 - Streamconverters (including decompressing) block off-main thread delivery?

Gary

Bug 1341266 - Set the highest priority when the transaction marked urgent-start on http2.

  • r?(mcmanus) Bug 1366932 - Add preference for JavaScript context heap size of PAC

  • r+(bagder) Bug 1366133 - Calling InternetGetConnectedStateExW() in ReadInternetOption() may cause hangs

  • WIP Bug 1328865 - moz-extension: URLs with fragment identifiers not resolved correctly in packed extensions

  • discussing

Junior

Bug 870460 - Lazy load of cookie service blocks main thread while cookie database loads

Bug 1158387 - Cookie DB shouldn't opt in to data corruption with "PRAGMA synchronous = OFF"

Land the dependent bugs

  • Bug 1370454 - Batch insertion for test_cookies_async_failure.js
  • Bug 1370456 - Batch operations for nsCookieService
  • Bug 867798 - Cookie Service closes DB on main thread

Amy

Bug 1331680 - Consider not doing sync IPC for document.cookie getter/setter

  • part 0: f+
  • part 1: f+
  • part 2: r+
  • part 3: f?
  • part 4: f?
  • part 5: f?
  • part 6: have been modifying test cases.

Kershaw

[CDP]

Bug 1360581 - HTTP channel TP annotation happens too late

  • labded?
  • Cause 3.x% performance regression on android

[Labeling]

Bug 1343743 - Label IPC actors in necko

  • landed Bug 1343755 - Label runnables in netwerk/sctp/datachannel/

  • r+ Bug 1343747 - Label runnables in WebSocket

  • landed

SC

[HttpChannel]

  • PBackground-ify HttpChannel IPC

  • Bug 1338493 - move HttpChannel IPC from main thread to STS thread in content process

    • fixing ServiceWorker redirect test case timeout

  • Bug 1369632 - 2.93% Quantum_1 (windows7-32) regression on push 12783b5a0fca4162a36a61b45f7b2a5bc2b452d1 (Thu Jun 1 2017)

  • onload time regress 15ms on google.com after PBackground HTTP IPC landed

  • main thread IPC "OnStartRequest" still blocks the ODA processing on content process

  • writing patch to move OnStartRequest to PBackground IPC

  • Bug 1371203

  • ChannelEventQueue raw pointer member variable issue

  • landed on m-c [random bug analysis]

  • Bug 1370177 - Can't play video in www.phim.media

  • MP4 demuxer might uses nsIHttpChannel.contentLength as the size of mp4 file, however it is not correct for compressed HTTP response

  • nsIHttpChannel.decodedBodySize is only available after OnStopRequest. Waiting until OnDataAvailable will get the correct mp4 file length.

  • Bug 1370783 - Intermittent netwerk/test/browser/browser_child_resource.js | uncaught exception - Error: Assertion failure at assert@chrome://browser/content/tabbrowser.xml:4227:25

  • complaining about missing do_QueryInterface() for coverting nsIChannel to nsIRequest.