2017-06-08

NECKO WEEKLY MEETING NOTES

Thurs May 31st, 2017

STICKY

  • Triage duty: dragana
  • new untriaged bugs: https://tinyurl.com/zhk9yjf
  • NECKO-ACTIVE bugs: https://tinyurl.com/j8pj35u
  • NECKO NEXT bugs: https://tinyurl.com/zjwjfee
  • NECKO-BACKLOG bugs: https://tinyurl.com/hpkcxx3

Round Table:

  • "Reference hardware" (3-4 Acer Laptops) so we have a standard for performance metrics
  • 1359624 - samba bin OSX crash

---PROJECT UPDATES--- - rust-url meeting notes: https://public.etherpad-mozilla.org/p/mozloha-rust-url - rcwn https://public.etherpad-mozilla.org/p/mozaloha-rcwn - service workers https://public.etherpad-mozilla.org/p/mozaloha-sw-necko

QUIC (Pat, Dragana, Daniel)

Race-Cache-with-Network (Michal, Valentin, Junior)

  • Enabled on nightly for a while
  • Next: land performance stats

Context-Driven Priority (Honza, Kershaw, Amy, Gary, Nick)

  • maybe we should give this a read? http://web.mit.edu/ravinet/www/polaris_nsdi16.pdf

PBackgroundHttp (SC, NIck)

Nick

  • NTLM Hell

Honza

Michal

  • 1368809 Assertion in nsHttpChannel::OnStopRequest when RCWN is enabled
  • 1370400 Assertion failure: mOnStartRequestCalled (OnStartRequest should be called before OnStopRequest)
  • 1367742 Crash in mozilla::net::nsHttpChannel::ContinueProcessRedirection
  • 1367810 Crash in mozilla::net::nsHttpChannel::CallOnStartRequest
  • 1368887 Crash in mozilla::net::CacheFile::IsKilled
  • 1369051 Assertion failure: !entry || !entry->IsFresh(), at /home/nicolas/mozilla/contrib-push/netwerk/cache2/CacheIndex.cpp:3129

Patrick

last week: mpendingq, 256fd telemetry, 0.9 telemetry, namespaces, neat tls, alt-svc, immutable bug, some non-necko stuff this week: neat tls, alt-svc, immutable bug, some non-necko stuff. more reviews.

Daniel

  • 1360164 - The first async XHR done during startup blocks the main thread while initializing nsProtocolProxyService
  • 1364250 - Move JAR channel I/O off of main thread
  • 1366222 - Basic authentication 401 message flood
  • mozquic (quic interim next week)

Valentin

bug 1359697 - don't poll for CP detection [landed]

bug 1356097 - investigate weird telemetry metrics [landed]

Bug 1368549 - Remove MOZ_WIDGET_GONK from netwerk/* [landed]

bug 945240 - make URLs hold punycode hosts

RCWN - telemetry should be available in the next few days, so we can see if it made any improvement

Looked into 1367810 - Crash in mozilla::net::nsHttpChannel::CallOnStartRequest

Dragana

TFO - second time: 2 crashes left

rel=preload

QUIC

Bug 1357678 - Streamconverters (including decompressing) block off-main thread delivery?

Gary

Bug 1341266 - Set the highest priority when the transaction marked urgent-start on http2.

  • r?(mcmanus) Bug 1366932 - Add preference for JavaScript context heap size of PAC

  • r+(bagder) Bug 1366133 - Calling InternetGetConnectedStateExW() in ReadInternetOption() may cause hangs

  • WIP Bug 1328865 - moz-extension: URLs with fragment identifiers not resolved correctly in packed extensions

  • discussing

Junior

Bug 1158387 - Cookie DB shouldn't opt in to data corruption with "PRAGMA synchronous = OFF"(backout)

Bug 867798 - Cookie Service closes DB on main thread (investigation)

Bug 1363659 - Prevent mozilla::ipc::FatalError from mozilla::net::PNeckoChild::SendP*Constructor (land)

Amy

Bug 1331680 - Consider not doing sync IPC for document.cookie getter/setter

  • part 0: f+
  • part 1: f-
  • part 2: f-
  • part 3: f-
  • part 4: f-
  • part 5: f-

Kershaw

[CDP]

Bug 1366822 - The active tab notification doesn't work when switching among windows

  • Still in discussion.

Bug 1360581 - HTTP channel TP annotation happens too late

  • f+
  • Ready to ask Francois to review

[Labeling]

Bug 1343743 - Label IPC actors in necko

  • r+
  • Need to pass Try server

SC

[HttpChannel]

  • PBackground-ify HttpChannel IPC

  • Bug 1015466 - PBackground-ify for ODA IPC

  • r+'ed for all patches, running try with rebased patches before landing.

  • Bug 1338493 - move HttpChannel IPC from main thread to STS thread in content process

    • f+ for the major patch
    • patch for one webRequest test failure is provided, need to find correct person to feedback
    • running TALOS and WPT to understand the performance difference.

  • Bug 1357689 - Implement nsIThreadRetargetableStreamListener in HttpChannelParent and HttpChannelParentListener

  • WIP provided

  • performance seems to be worse after the patch, under investigation

  • Bug 1353829 - 8% Are we slim yet regression found on autoland march 28th from revision e2a697abd5d3

    • resume the investigation, need to find a good STR for debugging the difference. [Quantum Flow]

  • Bug 1363421 - UserAgentOverrides.jsm is visible on startup profiles

    • landed on m-c

  • Bug 1365566 - Use PR_GetSystemInfo to get OS version instead of using system info

    • landed on m-c