2016-10-20

NECKO WEEKLY MEETING NOTES

Thurs Oct 19, 2016

STICKY

  • Triage duty:
  • new untriaged bugs: https://tinyurl.com/zhk9yjf
  • NECKO-ACTIVE bugs: https://tinyurl.com/j8pj35u
  • NECKO NEXT bugs: https://tinyurl.com/zjwjfee
  • NECKO-BACKLOG bugs: https://tinyurl.com/hpkcxx3

Round Table:

Nick

Honza

  • cache:
  • write backlog
  • frecency - is it the right way?
  • shutdown crashes
  • windows specific code (memmap)
  • net/cache racing (more aggressive)
  • windows IO hangs bug
  • new poll code, what to do with it
  • we should better track changes betweeen releases so we can more quickly find out cause of regressions on release/beta

Michal

  • 1310205 remove MOZ_ASSERT(entry->mRec->mFrecency == 0 || entry->mRec->mFrecency > mOldFrecency))
  • 1306969 Cache folder not empty after 'When Quit Clear Private Data - Cache'
  • 1311361 Crash in mozilla::net::CacheFileChunkBuffer::SetDataSize
  • CacheIndex (bugs 1272587, 1301562, 1201042, 1151887, 1151815)
  • RCWN

Patrick

last week: mpendingq, 256fd telemetry, 0.9 telemetry, namespaces, neat tls, alt-svc, immutable bug, some non-necko stuff this week: neat tls, alt-svc, immutable bug, some non-necko stuff. more reviews.

Daniel

ipv6 network identification code QUIC-team kicked off NEAT

Valentin

1239686 - set log file at runtime (landed)

1289001 - Crash in IPCError-browser | (msgtype=0xAE0005,name=PNecko::Msg_PHttpChannelConstructor) Value error: message was deserialized, b

*- child is sending null SerializedLoadInfo *- needinfo jduell Bug 1294719 - Crash in IPCError-content | (msgtype=0x820017,name=???) Route error: message sent to unknown actor ID

Dragana

Bug 1188435 - Support TCP fastopen

SDT

Bug 1289145 - PollEvent can block on Clear

Bug 1309681 - NSPR pipes became non-blocking by default

Gary

Bug 1288308 - Add support for named pipe connection to proxy.

  • r?(bagder, mayhemer) Bug 1311044 - non-existent Unix domain socket does not produce an error

  • r?(bagder) Bug 1311275 - Assertion failed in mozilla::net::nsIOService::GetCachedProtocolHandler

  • r?(mayhemer)

Junior

  • prepare study group materials and retrieve MDN and wiki https://goo.gl/FKXYMO

Amy

Bug 976073- prevent HTTP responses from setting cookies with secure flag

  • Josh r+

  • Daniel r-:have modified the suggestions from Daniel and understand his view on the spec. mailed to Josh for discussing the potential problem of FindStaleCookie() which is mentioned from Daniel. Bug 1293067 - (feature request): Implement a cookie limit warning

  • Ehsan r+, but still have to modify code from his suggestions.

  • Also needs to ask front-end peer to review the modifications of jsterm.js. Bug 1305380 - Crash in IPCError-browser | (msgtype=0x4E0001,name=PCookieService::Msg_GetCookieString) Processing error: message was deserializ

  • Created a document to arrange the potential files which maybe occur the crash. and listed all modifications between 6/1 to 8/1. But didn’t find any suspicious modifications.

  • In comment 11, the crash signature is gone now.

Kershaw

Bug 1305380 - Crash in IPCError-browser | (msgtype=0x4E0001,name=PCookieService::Msg_GetCookieString) Processing error: message was deserializ

  • Crash is gone after 20161010004016.

  • Could be related to PrincipalToPrincipalInfo in nsHostObjectURI::Serialize http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/dom/base/nsHostObjectURI.cpp#114 Bug 1257782 - DOS explot - hang with huge content-type header

  • Got f+ from Patrick

  • Still working on next patch

SC

  • trying BackTrack on Linux/Mac (build success but with runtime assertion)
  • setup BackTrack on Windows
  • defining performance test cases
    • small HTML with many external resources (JS /CSS)
    • huge single HTML file
    • huge image
    • small/large size of packet
    • from network or from cache